I fifth (?) Sergeant York. Great movie that isn't so much pro-gun as it is pro-defense of what is right. If you pick one, pick this one and skip all the shoot-em-ups.
Indiana Jones isn't "pro-gun", but you can't beat the swordsman scene. :)
Most older movies will show guns in a positive...