The great old guns of yesterday that we remember so fondly are the ones that WERE great guns. But there were LOTS-and-lots that weren't.
Sam has it exactly right. If those old guns were so great how come my Raven P-25 is such a POS? And I've seen worse, much worse going back to the 50's and before. How many derringers do you see around now? There's a reason they're gone. They were JUNK for the most part but I used to see lots of thing including some ridiculous designs that would almost certainly get someone hurt eventually. We saw lots of Topper shotguns in those days too. Not exactly top of the line stuff there and there were imitators of the Topper that were much worse. No we don't see them around now and there's a reason for that. They were junked a long time ago.
And let's talk about the great 1911. It's been around for 100 years and is the top of the food chain in the eyes of many. At one time you couldn't give one away where I lived. Many of them had terrible QC especially the government issued models. People wouldn't carry them because they had no reliability at all. The company that changed the image of the semi-auto (and people are gonna hate me for saying this) was GLOCK! They came out with a light weight, fairly inexpensive pistol that worked. Most didn't. Look at some of the early Ruger target pistols. The second generation became known as the MkII but the first really didn't have a name. And they wouldn't hit the broad side of a barn either. And I've seen Berettas that were absolute junk from those days. It was the "cheap Japanese quality" level gun (no they weren't Japanese but anything made in Japan in those days was the worst you could find so people lumped all junk in with the Japanese stuff). I remember seeing Beretta .25's that were worse than my Raven. If you think that's funny get this - Raven was actually seen as making good pistols at one time. Seriously.
We all tend to think that everything was Winchester or Remington and people forget even that Remington was blasted as being cheap junk at the time too. They said the fit and finish was nothing like the good old days blah blah blah.
Here's a peach of an example of a handgun a person might have seen back in those days. I saw a lot of guns there were similar to this in quality.
Here's a Beretta like I described before:
Does anyone really think this looks like a gun with a great finish?
It's true that rifles were better than handguns during the time but mainly we saw older designs still being sold like Winchester lever guns. We really didn't see that many rifles of any kind. If we saw someone that could shoot really well the chances are they were using the gun they learned to shoot in WWII, a Garrand.
But there were some cheap guns around like I showed in these photos. I know the gun mags like to promoted the idea that the old days were better but with gun mags you really need to follow the money. We don't see many ads for foreign rifles. Those gun mags have a vested interest in selling people on Remington and Ruger products because that's who pays their bills.
Look at these handguns and tell me that all guns in the good old days were better than they are now.