stchman said:
The Walther P1 is probably more of a collector's pistol and might command more of a price premium as I believe it is a WWII pistol.
The P1 is a post-WWII pistol, developed by Walther in 1954, originally with steel frames, and then converted to alloy. The German Army used them for a while. Early alloy models had problems, but as noted, later versions were reinforced. It's not likely to be much of a "collectible" gun as long as P-38s can be found -- and does nothing better the the P-38; it is a bit lighter. The P1 is a 75+-year old design -- it was better than the gun it replaced (the Luger, P-08), and that was it's chief virtue for the German Army. Individuals seemed to prefer the FN P-35 (Hi-Power), the factory was captured by Germany, when they had a choice -- that may have due, in part, to the FN's 13 round vs. the P-38's 8 round capacity.
Neither gun is ideal for "fun" plinking, but the S&W, with some gunsmithing, is both a serviceable weapon and likely to stand up to long-term use. It is a more modern design, originall based on the Glock design. (S&W was taken to court by Glock, lost, and had to change some internal features for patent infringements.)
If you can get the trigger worked on, you may find it a fine gun; if you can't (or don't) you can LEARN to shoot it well.
YOU CAME HERE FOR ADVICE, BUT YOU SEEM TO BE IGNORING AN IMPORTANT MESSAGE: YOU ARE NOT LIMITED TO THOSE TWO GUNS. THERE ARE BETTER CHOICES IN THE SAME PRICE RANGE.
But if you're determined to get one of those two, I'd get the S&W. Then, after a while, I'd have either S&W or a local gunsmith work on improving the trigger. Folks who have sent theirs back to S&W (shipping can be costly) are very pleased with the results.