As a retired attorney, I disagree with the advice that not everyone should have a will. There is always a possibility of something unforeseen happening that wasn't addressed in a trust, title or other disposition. Wills should be general in nature, however, with specific bequests easily changed without full formalities. In South Dakota it has long been determined an unethical practice to charge a percentage of the gross or net estate. This may have been common in some places many years ago, but currently any attorney who tries that will find themselves in hot water in this part of the country. We recommend avoiding probate when practical, but there are occasions when probate is useful.
Everyone should have a will, a durable power of attorney, and a living will or advance health care directive. Trusts can be very useful and are more private, but are not a panacea and should be used only if there is plenty of thought given to what can happen to people and assets over time. Some assets such as NFA items require disposition in a specific way to qualify for a no-tax transfer, and you want to make sure that if a recipient of a firearm becomes disqualified, appropriate alternative are clearly stated.